Hit&Run; patching
I keep coming across patches from random individuals on these here tubes with names like anonymous and NONAME. Posted to sourceforge and other places, why in Gods name sourceforge still allows this is beyond me. Sending random patches to an author or maintainer that you have a working relationship with is one thing. For instance if I receive a patch from lets say Daniel Lai for something. I've been friends with that kid since elementary school I'm aware of his mentality and don't really need to be concerned about patch application. Do you know Daniel Lai? Probably not. Do I know him? Yes. Do I know you? No. Technically, contacting through Sourceforge or some other online vcs repository would generally work if people actually checked their email they registered with. Others don't do this and I have just coined a term for these type of people, Hit&Run patchers.
A Hit&Run patcher is someone who sends you a patch with no relevant information about the patch. Usually by email but also by just posting a patch to a project website somewhere in a corner with no other discernable information than the patch itself. If one is lucky an obscure username like 'asdf1234' or 'Anonymous' is left with the relevant patch. Usually these are small patches but every once in a while a large patch is left. This is usually a bad thing as then you the maintainer of the project have to apply the patch. Summarily then figuring out what exactly it is doing. 9 times out of 10 it's formatted incorrectly and needs various correcting. If you are reading this definition you've probably received a Hit&Run patch. You should feel free to put it on the back-burner and attend to those patches that have been properly described.
Being a Hit&Run patcher is akin to someone slapping you in the face rudely with an answer to a question you've simply never asked. "*SLAP* Here's an answer bitch, 42, try figuring out what the question is.. SUCKKKERRRR". It's just wholly unacceptable social behavior and should be tolerated by no one!
So, yes. I have done this myself, fixed something and just send the patch from some random internet cafe in the furthest most inhabited island-right in the Atlantic Ocean. Normally to whatever email that resembles maintainer or author. I will flog myself later. This behavior however is unacceptable! Certainly practicing being a Hit&Run patcher means I should not expect my patch to be applied. Or if it is applied I should expect it will take more time than is reasonable as the maintainer tries to figure out the question to his/her life, the universe and then this anonymous patch. Really, my only complaint should be with myself as certainly this would be fine. Well, if not for me wanting my patch applied to trunk.
So what have we learned? When one submits a patch as anonymous it is simply a really bad way to go about getting said patch accepted. There are a couple of things that are just formally required for kind, civilized society to continue existence. These things primarily for tracking, accreditation and communication purposes.
- A working valid email address. In-case one needs to be contacted about the patch or commentary.
- A valid name. Even if it's just a handle; so the author or maintainer may attribute credit for said patch
Everything else can be negotiated but at the very least the above two items are absolutely required. What would help even more is discussing your patch and what it does in a sane rational manner. Something along the lines of "This changes XYZ in X function/class/method/whatever and achieves X functionality". Also, why you feel your patch should be applied as in "This will help users in this corner case for which no current functionality exist" or "This fixes a bug or security hole based on the samples that I have provided". All that said it makes the life of the maintainer or author of the package so much more pleasant! When the patch comes with the above material it's simple to look at the code or patch and say. "This person knows what they are doing, they've provided a valid patch that adheres to the functionality described and it fits within the guidelines of the project; they've provided all needed facets. I've spoken with them, there's nothing left to do but apply the patch for cut in a new release". Anything else is barbaric.
Next time you come across a Hit&Run patcher feel free to relay them this link in whatever forum they've posted their patch.
Syndicated 2010-04-17 18:58:51 from Christopher Warner » Advogato